Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct msg.sender in emojimon #3277

Merged
merged 1 commit into from
Oct 12, 2024
Merged

docs: correct msg.sender in emojimon #3277

merged 1 commit into from
Oct 12, 2024

Conversation

three9s
Copy link
Contributor

@three9s three9s commented Oct 12, 2024

In Solidity, msg.sender is not a function, so the docs are incorrect and this is confusing. This corrects it so it makes sense.

Copy link

changeset-bot bot commented Oct 12, 2024

⚠️ No Changeset found

Latest commit: f40c4f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@holic holic merged commit e8b1dbb into latticexyz:main Oct 12, 2024
1 of 3 checks passed
@three9s three9s deleted the docs-1 branch October 12, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants