Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explorer): allow overriding internal indexer env variables #3237

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Sep 26, 2024

No description provided.

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 8e573af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/explorer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
mock-game-contracts Patch
ts-benchmarks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ❌ Failed (Inspect) Sep 26, 2024 1:01pm

@alvrs alvrs marked this pull request as ready for review September 26, 2024 12:59
DEBUG: "mud:*",
RPC_HTTP_URL: "http://127.0.0.1:8545",
FOLLOW_BLOCK_TAG: "latest",
SQLITE_FILENAME: indexerDatabase,
STORE_ADDRESS: worldAddress,
...process.env,
Copy link
Member

@holic holic Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explorer env could prob use a bit of a refactor with a similar approach but don't need to block on that here

e.g. env object filled in based on flags and then override at the end with process.env to let env vars pass through

@alvrs alvrs merged commit 85bbeb8 into main Sep 26, 2024
13 of 14 checks passed
@alvrs alvrs deleted the alvrs/explorer-local-env branch September 26, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants