Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(phaserx): allow for multiple tweens on same objects by passing in… #122

Merged
merged 3 commits into from
Aug 5, 2022
Merged

fix(phaserx): allow for multiple tweens on same objects by passing in… #122

merged 3 commits into from
Aug 5, 2022

Conversation

davidkol
Copy link
Contributor

@davidkol davidkol commented Aug 4, 2022

… control flags

  • added optional flags for controlling the stopping of tweens in phaser
  • made the phaser game object reset util function set alpha to 1

@davidkol davidkol requested review from Kooshaba and alvrs August 4, 2022 22:05
alvrs
alvrs reviewed Aug 5, 2022
View reviewed changes
packages/phaserx/src/types.ts Outdated Show resolved Hide resolved
@alvrs alvrs merged commit d129836 into main Aug 5, 2022
@alvrs alvrs deleted the david/fix-tweens branch August 23, 2022 09:50
LPSCRYPT pushed a commit to LPSCRYPT/esp that referenced this pull request Jan 23, 2023
@davidkol @alvrs
fix(phaserx): allow for multiple tweens on same objects by passing in… (
3bbc004 
latticexyz#122)

* fix(phaserx): allow for multiple tweens on same objects by passing in control flags

* fix(phaserx): fix breaking change on embodiedEntity.removeComponent

* fix: make stop flag optional in types

Co-authored-by: alvarius <89248902+alvrs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs alvrs approved these changes

@Kooshaba Kooshaba Awaiting requested review from Kooshaba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidkol @alvrs