Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gas-report): create package, move relevant files to it #1147

Merged
merged 11 commits into from
Jul 12, 2023

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Jul 11, 2023

fixes #667

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

🦋 Changeset detected

Latest commit: 8a5f968

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@latticexyz/cli Minor
@latticexyz/gas-report Minor
@latticexyz/store Minor
@latticexyz/std-client Patch
@latticexyz/world Patch
@latticexyz/network Patch
@latticexyz/react Patch
@latticexyz/store-cache Patch
@latticexyz/store-sync Patch
@latticexyz/dev-tools Patch
@latticexyz/ecs-browser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic
Copy link
Member

holic commented Jul 11, 2023

thoughts on refactoring gas report TS to be more of a output parser than a test runner?

@dk1a
Copy link
Contributor Author

dk1a commented Jul 11, 2023

thoughts on refactoring gas report TS to be more of a output parser than a test runner?

if you mean to separate it into a parser and a runner that seems nice if not particularly important;
either way I'd rather keep this PR simple, and move on to gas optimizations

@@ -1,4 +1,4 @@
lockfileVersion: '6.1'
lockfileVersion: '6.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which version of pnpm are you currently on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.6.7

Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! would you mind adding a simple example for how to use the gas report to the readme and adding a changeset?

@dk1a
Copy link
Contributor Author

dk1a commented Jul 11, 2023

adding a changeset

I'm assuming we don't want to strictly follow semver for now and avoid major

@dk1a dk1a marked this pull request as ready for review July 11, 2023 20:11
@dk1a dk1a requested a review from holic as a code owner July 11, 2023 20:11
holic
holic previously approved these changes Jul 12, 2023
This reverts commit c9f0d4b.
@dk1a dk1a merged commit 66cc35a into main Jul 12, 2023
8 of 9 checks passed
@dk1a dk1a deleted the dk1a/gas-reporter branch July 12, 2023 12:30
@dk1a
Copy link
Contributor Author

dk1a commented Jul 12, 2023

(tried fiddling with e2e but then figured it shouldn't be part of this PR and merged as it was when @holic approved it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move gas report out of cli?
3 participants