-
Notifications
You must be signed in to change notification settings - Fork 109
Maximal vectorization #1548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maddyscientist
wants to merge
81
commits into
develop
Choose a base branch
from
feature/vectorize
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Maximal vectorization #1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essors. Remove any explicit use of gauge::FloatNOrder in "user code" to ensure that the order is not hard coded anywhere. Maximal vectorization not enable anywhere yet (since not applied to fine-grained accessor yet)
… allow us to remove the type punning in the accessors
…rder used for double and single precision as CMake parameters (QUDA_ORDER_DOUBLE and QUDA_ORDER_SINGLE). Removed some casting of stack variables
…esent). To enable, set QUDA_ORDER to 0
…he same information
…eCB, to reduce IMAD overhead. Remove DslashArg::ghostFace
…CIe bus id to ensure consistency
… for all load/store to shared memory to be done using immediates. Left disabled for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a significant cleanup and reworking of the native QUDA accessors.
FLOAT2
,FLOAT4
,FLOAT8
data orderings, we now just haveNATIVE
orderingCMake
parametersQUDA_ORDER_DOUBLE
,QUDA_ORDER_SINGLE
,QUDA_ORDER_HALF
,QUDA_ORDER_QUARTER
FLOAT4
accessorFLOAT4
accessor, we would have 4xFLOAT4
ld/st instructions and a 1xFLOAT2
remainder.The motivation for this work is to increase the use of vectorized load and stores, to improve performance on more recent GPUs.