Simplify packet dissector to eliminate incoming buffer #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An off by one bug was causing packets to be dropped when they matched the PACKET_MAX_SIZE exactly, leaving the _protocolBuffer in a reset state.
…fer, free about 256 bytes of memory <3
|
Thanks @Bluebie , super modif - the buffer was not needed and we save a lot of memory (making it fit into an Uno again). I noticed that you did not add your name to the authors - if OK with you, I will add you manually (no need to do an additional pull request) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminating incoming buffer will limit damaging effects of confusing or corrupted packets, free up a couple hundred bytes of global memory, speed up incoming packet processing, and get rid of a place bugs were hiding.