Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid writing tex for #1412 #1466

Merged
merged 9 commits into from
Sep 15, 2024
Merged

avoid writing tex for #1412 #1466

merged 9 commits into from
Sep 15, 2024

Conversation

davidcarlisle
Copy link
Member

@davidcarlisle davidcarlisle commented Sep 12, 2024

Status of pull request

  • ready to merge

Currently no changelog or ltnews item, just looking for review on the mechanism
(write a file with non-empty base then use an overloaded l3build unpack bundleunpack function
to rename at the end.

As far as I can see the l3build texlua script renaming a file via os.execute{mv ...
is not subject to the restriction on writing .tex. (confirmed by Karl in the associated issue)

@josephwright
Copy link
Member

Plan looks entirely sensible to me

Co-authored-by: Yukai Chou <muzimuzhi@gmail.com>
Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me (give or take the missing bits)

@davidcarlisle davidcarlisle marked this pull request as ready for review September 12, 2024 20:43
Copy link
Contributor

@muzimuzhi muzimuzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small polishments.

required/tools/build.lua Outdated Show resolved Hide resolved
base/doc/ltnews40.tex Outdated Show resolved Hide resolved
required/tools/build.lua Outdated Show resolved Hide resolved
davidcarlisle and others added 3 commits September 12, 2024 22:25
Co-authored-by: Yukai Chou <muzimuzhi@gmail.com>
Co-authored-by: Yukai Chou <muzimuzhi@gmail.com>
Co-authored-by: Yukai Chou <muzimuzhi@gmail.com>
@josephwright josephwright merged commit 0ba366a into develop Sep 15, 2024
84 checks passed
@josephwright josephwright deleted the gh1412 branch September 15, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants