Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LaTeX file list in project detection #1160

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Conversation

pfoerster
Copy link
Member

Adds a parser for the .fls file that lists the working directory and all files processed during compilation. This can aid as a fallback when the regular syntax-based project detection fails due to macro definitions.

Fixes #1145.

@pfoerster pfoerster merged commit 27625c9 into master Jul 6, 2024
6 checks passed
@pfoerster pfoerster deleted the feature/parse-fls-file branch July 6, 2024 07:29
@clason
Copy link
Contributor

clason commented Jul 8, 2024

For larger projects, this can lead to a significant regression in startup time (I have one with a ~2300 line .fls file, for which texlab now needs ~25s to spin up where it was near instant (<1s) before -- on the same project!)

Can this be enabled conditionally, or made opt-in/out?

@pfoerster
Copy link
Member Author

@clason Does #1164 restore the original startup time?

@clason
Copy link
Contributor

clason commented Jul 8, 2024

Yes, it does, thank you!

(For the record, I'd be fine with it being opt-out; I suspect that projects such as this are the exception rather than the rule -- although probably not so rare.)

@pfoerster
Copy link
Member Author

For the record, I'd be fine with it being opt-out; I suspect that projects such as this are the exception rather than the rule -- although probably not so rare.

For now, I'd rather keep it fast and enable it by default once it's fast enough that it doesn't impact performance (that much).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bib reference error for subimports
2 participants