Skip to content

Conversation

sarroutbi
Copy link
Collaborator

@sarroutbi sarroutbi commented May 5, 2023

Change meson.build to include new release, that will contain latest fixes in tang repository

Resolves: #112

Proposed changelog:

  • Add v2 version for codecov action (#1fcfdb6)
  • socket: fix possible buffer overflow in listen_port() (#9b9d149)
  • socket: free socket list before exiting (#5631569)
  • tests: make sure on_exit handler completes (#0cacc91)
  • tests: fix wait_for_port() retry mechanism (#5160a4a)
  • use sigaction instead of signal for SIGCHLD processing (#f44f4ec)
  • tangd.socket: Set ownership and mode of jwkdir (#ae736c9)

Copy link
Collaborator

@sergio-correia sergio-correia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarroutbi sarroutbi changed the title Create new release (v13) Create new release (version 13) May 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9b9d149) 57.22% compared to head (a1f3ecd) 57.22%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   57.22%   57.22%           
=======================================
  Files           4        4           
  Lines         547      547           
  Branches      145      145           
=======================================
  Hits          313      313           
  Misses        133      133           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sarroutbi sarroutbi force-pushed the release_v13 branch 2 times, most recently from a1f3ecd to ff60803 Compare May 5, 2023 13:08
@sergio-correia
Copy link
Collaborator

Please, rebase this PR before merging, it now has 2 commits.

Copy link
Collaborator

@sergio-correia sergio-correia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but fix the PR first, please.

Resolves: latchset#112

Proposed changelog:
Add v2 version for codecov action (#1fcfdb6)
socket: fix possible buffer overflow in listen_port() (#9b9d149)
socket: free socket list before exiting (#5631569)
tests: make sure on_exit handler completes (#0cacc91)
tests: fix wait_for_port() retry mechanism (#5160a4a)
use sigaction instead of signal for SIGCHLD processing (#f44f4ec)
tangd.socket: Set ownership and mode of jwkdir (#ae736c9)

Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi merged commit ea54169 into latchset:master May 5, 2023
@sarroutbi sarroutbi deleted the release_v13 branch May 5, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release version 13
3 participants