Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sigaction instead of signal for SIGCHLD processing #110

Merged
merged 1 commit into from
May 5, 2023

Conversation

phirince
Copy link
Contributor

@phirince phirince commented Apr 26, 2023

The issue being handled is explained in this issue: #109

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.24 🎉

Comparison is base (7c0d86f) 55.88% compared to head (d5ee7b0) 56.12%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   55.88%   56.12%   +0.24%     
==========================================
  Files           4        4              
  Lines         544      547       +3     
  Branches      145      145              
==========================================
+ Hits          304      307       +3     
  Misses        140      140              
  Partials      100      100              
Impacted Files Coverage Δ
src/socket.c 51.78% <100.00%> (+1.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Change LGTM.

@sarroutbi sarroutbi requested a review from sergio-correia May 3, 2023 07:23
@sarroutbi
Copy link
Collaborator

@sergio-correia: can you please double-check this?

Copy link
Collaborator

@sergio-correia sergio-correia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sergio-correia sergio-correia merged commit 6313a9e into latchset:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants