Fix tests for scala 2.13 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nning on local machine
Scala 2.12 and 2.13 give different outputs for toString
|
|
|
Circle CI built successfully |
|
@karolchmist Thanks a lot for your contribution! This looks great. I'm merging it now and will publish a new version soon. The use of |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've managed to fix tests on
circleci-20-testbranch. I took your commits @lastland and squashed them to just one for a starting point.This fixed #48
I just wanted at first to help and fix MySQL tests, but there were more things not working, so I took a deep dive and changed more stuff.
I hope that the commit messages are self-explanatory :)
The only thing that I'm not very happy about is using
rootuser to run MySQL tests. I don't know why using env variables doesn't work, but maybe it could be fixed later. There is another solution of adding a user manually, which can be found on a separate branch.