[MapleLib] Fixed copyright header parsing (#77) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes parsing for copyright parsing in the WZ file's header and therefore, fixes parsing for WZ files that were produced by the ancient versions of HaCreator.
Arnuh
reviewed
Nov 5, 2020
| this.Header.Copyright = reader.ReadString((int)(Header.FStart - 17U)); | ||
|
|
||
| reader.ReadBytes(1); | ||
| reader.ReadBytes((int)(Header.FStart - (ulong)reader.BaseStream.Position)); |
There was a problem hiding this comment.
From what I see the proper way would be just to not do these 2 byte reads and instead move the reader.BaseStream.Position to Header.FStart
There was a problem hiding this comment.
as much as I'd like to do that, that would break the header upon saving the file (we should read the data - not skip it)
|
Looks ok in my testing on GMS v83, v188. SEA v15, 198. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77.
This patch fixes parsing for the copyright part in the WZ file's header and therefore, fixes parsing for WZ files that were produced by the ancient versions of HaCreator. I found that the issue happens because the game client reads a fixed amount of bytes for the copyright string however the old version of MapleLib for some reason wrote a 50 instead of a 0 (null terminator) at the end of the string, therefore -- breaking it all apart
It's a bit hacky (and hardcoded). I accomplished it by reversing the parsing from the MapleLib library I had which happened to have the correct parsing patched into it.
I have tested this patch on various WZ files including stock v83, a variety of modded v83s, stock v84, v92, v95, v127, v162, v176, stock v179, Kastia's v179, v213.. all seems well!