Fixes and Improvements #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted - default encryption aligns with the selection on MainForm's tool strip - changing encryption correctly and only applies to the WZ file being created/saved - changing encryption does not affect the current selection on MainForm's tool strip
|
LGTM! merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have made some changes and bugfixes since #253, mainly focus on NewForm and SaveForm, as these 2 dialogs were not correctly handling encryptionbox selection changes, which causes creating and saving wz files with wrong encryption.
Here’s how I envision the expected behavior of the encryptionbox in NewForm/SaveForm dialogs. Please share if you have any alternative ideas: