HaCreator - 64 Bit Client #171

SoulGirlJP · 2022-03-16T15:37:14Z

I made an option to switch between 32 bit client and 64 bit client compatible, maybe its not optimal way and could just make the thing detect if it contains a Data folder, but anyways here is my take feel free to make it better, there is couple of issues like map simulator and some tile display issue not working, but i think the rest should be fine, it might need to get looked into it more since obviously not that perfect, like Map9_001.wz still needs to be loaded as i didn`t find a way to do this couple of things missing, but wanted to contribute to the community much love <3

I made an option to switch between 32 bit client and 64 bit client, maybe its not optimal way and could just make the thing detect if it contains a Data folder, but anyways here is my take feel free to make it better, there is couple of issues like map simulator and some tile display issue not working, but i think the rest should be fine

lastbattle · 2022-03-19T03:05:05Z

Hi, I would appreciate if you are able to pull from the latest master branch, then opening up another pull request. I'll merge them.
It is overriding some of my prior changes.

Thanks a lot!

SoulGirlJP · 2022-03-20T23:53:24Z

Ohhh yeh sure

This reverts commit f55a794, reversing changes made to c2bb9a6.

This reverts commit e704a3f.

dunno wouldn't work without manually adding it for some reasons

SoulGirlJP · 2022-03-23T00:10:31Z

Yeh i dunno why i am having such a hard time with Github

lastbattle · 2022-03-23T06:55:20Z

It might be easier by just pulling the latest branch, and manually making the changes once again 🤔
I'll merge them once you are done, and integrate them later.

SoulGirlJP · 2022-03-24T22:32:39Z

Hmm yeh ill just do it next week

Pulled Last changes and redid everything

SoulGirlJP · 2022-11-08T20:27:25Z

After a long break i have decided to come back and pulled the latest changes as asked before, and i completely redid since i had a lot of issues with the last pull so i just pulled and redid all the code necessary to make it work again, as mentioned there is a lot of work to do still, i just wanted to help out the community and help the open source as best to my ability, if there is any questions please let me know! Much love <3

lastbattle · 2022-11-09T15:18:57Z

I will take a look this weekend! Thanks a lot for your help, I appreciate it!!

shailist

glossed around the changes and left some suggestions for cleaner code.
didn't really look into the internals and didn't verify if it even worked 🤷, but looks good

shailist · 2022-11-17T22:38:56Z

HaCreator/GUI/Initialization.cs

                // Load sound
-                foreach (string soundWzFile in WzFileManager.SOUND_WZ_FILES)
+
+                if (isClient64())
                {
-                    textBox2.Text = string.Format("Initializing {0}.wz...", soundWzFile);
-                    Application.DoEvents();
-                    Program.WzManager.LoadWzFile(soundWzFile.ToLower());
-                    Program.WzManager.ExtractSoundFile(soundWzFile.ToLower());
+                    foreach (string soundWzFile in WzFileManager.SOUND_WZ_FILES_64)
+                    {
+                        textBox2.Text = string.Format("Initializing {0}.wz...", soundWzFile);
+                        Application.DoEvents();
+                        Program.WzManager.LoadWzFile(soundWzFile.ToLower());
+                        Program.WzManager.ExtractSoundFile(soundWzFile.ToLower());
+                    }
+                } else
+                {
+                    foreach (string soundWzFile in WzFileManager.SOUND_WZ_FILES)
+                    {
+                        textBox2.Text = string.Format("Initializing {0}.wz...", soundWzFile);
+                        Application.DoEvents();
+                        Program.WzManager.LoadWzFile(soundWzFile.ToLower());
+                        Program.WzManager.ExtractSoundFile(soundWzFile.ToLower());
+                    }


the only difference is which files we iterate, the loop is the same:

// Load sound var soundWzFiles = isClient64() ? WzFileManager.SOUND_WZ_FILES_64 : WzFileManager.SOUND_WZ_FILES; foreach (string soundWzFile in soundWzFiles ) { textBox2.Text = string.Format("Initializing {0}.wz...", soundWzFile); Application.DoEvents(); Program.WzManager.LoadWzFile(soundWzFile.ToLower()); Program.WzManager.ExtractSoundFile(soundWzFile.ToLower()); }

shailist · 2022-11-17T22:40:17Z

HaCreator/GUI/Initialization.cs

-                foreach (string mapwzFile in WzFileManager.MAP_WZ_FILES)
+                if (isClient64())
                {
-                    if (Program.WzManager.LoadWzFile(mapwzFile.ToLower()))
+                    foreach (string mapwzFile in WzFileManager.MAP_WZ_FILES_64)
                    {
-                        textBox2.Text = string.Format("Initializing {0}.wz...", mapwzFile);
-                        Application.DoEvents();
-                        Program.WzManager.ExtractBackgroundSets();
-                        Program.WzManager.ExtractObjSets();
+                        if (Program.WzManager.LoadWzFile(mapwzFile.ToLower()))
+                        {
+                            textBox2.Text = string.Format("Initializing {0}.wz...", mapwzFile);
+                            Application.DoEvents();
+                            Program.WzManager.ExtractBackgroundSets();
+                            Program.WzManager.ExtractObjSets();
+                        }
                    }
                }
+                else
+                {
+                    foreach (string mapwzFile in WzFileManager.MAP_WZ_FILES)
+                    {
+                        if (Program.WzManager.LoadWzFile(mapwzFile.ToLower()))
+                        {
+                            textBox2.Text = string.Format("Initializing {0}.wz...", mapwzFile);
+                            Application.DoEvents();
+                            Program.WzManager.ExtractBackgroundSets();
+                            Program.WzManager.ExtractObjSets();
+                        }
+                    }
+                }


shailist · 2022-11-17T22:43:59Z

HaCreator/MapEditor/Info/MobInfo.cs

+            if (Initialization.isClient64())
            {
-                WzImage mobImage = (WzImage)Program.WzManager[mobWzFile.ToLower()]?[id + ".img"];
-                if (mobImage == null)
-                    continue;
-
-                if (!mobImage.Parsed)
+                foreach (string mobWzFile in WzFileManager.MOB_WZ_FILES_64)
                {
-                    mobImage.ParseImage();
+                    WzImage mobImage = (WzImage)Program.WzManager[mobWzFile.ToLower()]?[id + ".img"];
+                    if (mobImage == null)
+                        continue;
+
+                    if (!mobImage.Parsed)
+                    {
+                        mobImage.ParseImage();
+                    }
+                    if (mobImage.HCTag == null)
+                    {
+                        mobImage.HCTag = MobInfo.Load(mobImage);
+                    }
+                    MobInfo result = (MobInfo)mobImage.HCTag;
+                    result.ParseImageIfNeeded();
+                    return result;
                }
-                if (mobImage.HCTag == null)
+                return null;
+            } else
+            {
+                foreach (string mobWzFile in WzFileManager.MOB_WZ_FILES)
                {
-                    mobImage.HCTag = MobInfo.Load(mobImage);
+                    WzImage mobImage = (WzImage)Program.WzManager[mobWzFile.ToLower()]?[id + ".img"];
+                    if (mobImage == null)
+                        continue;
+
+                    if (!mobImage.Parsed)
+                    {
+                        mobImage.ParseImage();
+                    }
+                    if (mobImage.HCTag == null)
+                    {
+                        mobImage.HCTag = MobInfo.Load(mobImage);
+                    }
+                    MobInfo result = (MobInfo)mobImage.HCTag;
+                    result.ParseImageIfNeeded();
+                    return result;
                }
-                MobInfo result = (MobInfo)mobImage.HCTag;
-                result.ParseImageIfNeeded();
-                return result;
+                return null;


Pushed! thanks.
b37108a

Alon-Sachs · 2022-11-19T17:09:13Z

is there a way to add this to harepacker aswell?

SoulGirlJP · 2022-11-19T20:31:47Z

Harepacker already works

…

On Sat., Nov. 19, 2022, 12:09 p.m. Alon-Sachs, ***@***.***> wrote: is there a way to add this to harepacker aswell? — Reply to this email directly, view it on GitHub <#171 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMJFFTYLT4FTURZUZK5KHNTWJECUJANCNFSM5Q4IKWBQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

Lingko621 · 2022-11-24T08:51:54Z

how can i use this program? and it works?
if it works send me file please ToT

lastbattle · 2022-11-28T00:15:20Z

Merged! I'll do a little clean up later, once again really thanks a lot for the contribution.

SoulGirlJP · 2022-11-28T00:48:14Z

You are very welcome! I'm happy i was able to help!

…

On Sun., Nov. 27, 2022, 7:15 p.m. LastBattle, ***@***.***> wrote: Merged! I'll do a little clean up later, once again thanks for the contribution! — Reply to this email directly, view it on GitHub <#171 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMJFFTYK2YXDZR6OKLQ3V4DWKP2SHANCNFSM5Q4IKWBQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

lastbattle · 2022-12-02T08:02:38Z

Made it a little better 🫡 It'll allow for better support for future versions of .wz files, as the location of the images, and directories are actually not static from versions to versions.

cee77e2

GMS v237

SoulGirlJP · 2022-12-02T21:57:02Z

Amazing work, i wanted to do this too but i felt lazy haha good job! Le ven. 2 déc. 2022 à 03:02, LastBattle ***@***.***> a écrit :

…

I've made it better, feel free to take a look! It'll allow for better support for future versions of .wz files, as the location of the images, and directories are not static. cee77e2 <cee77e2> — Reply to this email directly, view it on GitHub <#171 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMJFFT2K4FAJTHQICYCFIPDWLGUKRANCNFSM5Q4IKWBQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

lastbattle · 2022-12-03T02:58:36Z

Exactly!! It was just so tedious and time consuming.
That was the reason why I avoided doing it months after 64-client was released.
It kept being pushed back and at the same time I was busy on other personal stuff. I guess this pull request kind of forced me to 😀

SoulGirlJP · 2022-12-07T00:41:11Z

Ahhh i see yeah well it's understandable hahahaha Le ven. 2 déc. 2022 à 21:58, LastBattle ***@***.***> a écrit :

…

Exactly!! It was just so tedious. That was the reason why I avoided doing it months after 64-client was released. It kept being pushed back and at the same time I was busy on other personal stuff. I guess this pull request kind of forced me to 😀 — Reply to this email directly, view it on GitHub <#171 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMJFFT2NKZSN4I3BV7DXJRTWLKZORANCNFSM5Q4IKWBQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

SoulGirlJP changed the title ~~HaCreator - 64 for Bit client~~ HaCreator - 64 Bit client Mar 16, 2022

SoulGirlJP changed the title ~~HaCreator - 64 Bit client~~ HaCreator - 64 Bit Client Mar 16, 2022

SoulGirlJP added 3 commits March 20, 2022 21:34

Revert "Merge pull request lastbattle#163 from lastbattle/staging"

cbfd378

This reverts commit f55a794, reversing changes made to c2bb9a6.

Revert "HaCreator for 64 bit clients"

cc7c90a

This reverts commit e704a3f.

Needed

508570f

dunno wouldn't work without manually adding it for some reasons

terjun mentioned this pull request Jul 5, 2022

[HaCreator] can't even start #179

Closed

Hacreator fixed

c22ce75

Pulled Last changes and redid everything

SoulGirlJP closed this Nov 8, 2022

SoulGirlJP reopened this Nov 8, 2022

shailist suggested changes Nov 17, 2022

View reviewed changes

lastbattle merged commit b67973b into lastbattle:master Nov 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HaCreator - 64 Bit Client #171

HaCreator - 64 Bit Client #171

SoulGirlJP commented Mar 16, 2022

lastbattle commented Mar 19, 2022 •

edited

Loading

SoulGirlJP commented Mar 20, 2022

SoulGirlJP commented Mar 23, 2022

lastbattle commented Mar 23, 2022 •

edited

Loading

SoulGirlJP commented Mar 24, 2022

SoulGirlJP commented Nov 8, 2022

lastbattle commented Nov 9, 2022

shailist left a comment

shailist Nov 17, 2022

shailist Nov 17, 2022

shailist Nov 17, 2022

lastbattle Nov 30, 2022

Alon-Sachs commented Nov 19, 2022

SoulGirlJP commented Nov 19, 2022 via email

Lingko621 commented Nov 24, 2022

lastbattle commented Nov 28, 2022 •

edited

Loading

SoulGirlJP commented Nov 28, 2022 via email

lastbattle commented Dec 2, 2022 •

edited

Loading

SoulGirlJP commented Dec 2, 2022 via email

lastbattle commented Dec 3, 2022 •

edited

Loading

SoulGirlJP commented Dec 7, 2022 via email

HaCreator - 64 Bit Client #171

HaCreator - 64 Bit Client #171

Conversation

SoulGirlJP commented Mar 16, 2022

lastbattle commented Mar 19, 2022 • edited Loading

SoulGirlJP commented Mar 20, 2022

SoulGirlJP commented Mar 23, 2022

lastbattle commented Mar 23, 2022 • edited Loading

SoulGirlJP commented Mar 24, 2022

SoulGirlJP commented Nov 8, 2022

lastbattle commented Nov 9, 2022

shailist left a comment

Choose a reason for hiding this comment

shailist Nov 17, 2022

Choose a reason for hiding this comment

shailist Nov 17, 2022

Choose a reason for hiding this comment

shailist Nov 17, 2022

Choose a reason for hiding this comment

lastbattle Nov 30, 2022

Choose a reason for hiding this comment

Alon-Sachs commented Nov 19, 2022

SoulGirlJP commented Nov 19, 2022 via email

Lingko621 commented Nov 24, 2022

lastbattle commented Nov 28, 2022 • edited Loading

SoulGirlJP commented Nov 28, 2022 via email

lastbattle commented Dec 2, 2022 • edited Loading

SoulGirlJP commented Dec 2, 2022 via email

lastbattle commented Dec 3, 2022 • edited Loading

SoulGirlJP commented Dec 7, 2022 via email

lastbattle commented Mar 19, 2022 •

edited

Loading

lastbattle commented Mar 23, 2022 •

edited

Loading

lastbattle commented Nov 28, 2022 •

edited

Loading

lastbattle commented Dec 2, 2022 •

edited

Loading

lastbattle commented Dec 3, 2022 •

edited

Loading