Separate workflow from nuget publishing #546
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
ci/separate-workflow-from-nuget-publishing
branch
from
7c24c72 to
b0305bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR separates the main PR workflow from nuget publishing. Forks while preferred, should also be treated as unsafe until verified. A safer approach for accessing secrets when building NuGet packages from fork PRs is to use a separate workflow triggered by workflow run. This allows one to have a CI workflow on the pull_request event (without secrets) for basic build and test, and then a subsequent workflow (with secrets) that can handle package publishing after the initial CI has passed and the code is deemed safe.
Verification
Will be tested against a branch with results visible in github actions reports.
Documentation
None
Future work
None