Added more bench #405
Merged
Added more bench #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barambani
commented
Jan 3, 2021
| @@ -41,12 +39,10 @@ private[laserdisc] final case class CompleteFrame(bits: BitVector) extends NonEm | |||
| private[laserdisc] final case class MoreThanOneFrame(private[laserdisc] val complete: Vector[CompleteFrame], remainder: BitVector) | |||
| extends NonEmptyRESPFrame | |||
| private[laserdisc] final case class IncompleteFrame(partial: BitVector, bitsToComplete: Long) extends NonEmptyRESPFrame { | |||
| override def append(bytes: ByteBuffer): Exception | NonEmptyRESPFrame = { | |||
| val newBits = BitVector.view(bytes) | |||
| override def append(bits: BitVector): Exception | NonEmptyRESPFrame = | |||
There was a problem hiding this comment.
here's the only real change to production code, and it's more a clean up of unneeded conversions than a performance improvement.
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
==========================================
- Coverage 62.84% 62.81% -0.03%
==========================================
Files 38 38
Lines 1281 1280 -1
Branches 8 8
==========================================
- Hits 805 804 -1
Misses 476 476
Continue to review full report at Codecov.
|
sirocchj
approved these changes
Jan 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds details to the benchmarks. This is a decently long run of them
it seems that converting to bit vector or decoding response messages doesn't add much, so the bottleneck must be somewhere else (I guess in fs2.io that's much slower than that). What seems to cost is the send. Every stage adds a bit.
I haven't tried to speed up things, anyway considering that our baseline is much slower than other clients I would say we stop here the effort for performances and we see how other client designs look like.