Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parallel test cases, refactored parallel benchmarks #310

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Added parallel test cases, refactored parallel benchmarks #310

merged 2 commits into from
Aug 5, 2020

Conversation

barambani
Copy link
Member

This gives the following information on a slowish machine:

Benchmark                                               Mode  Cnt      Score     Error  Units
ParallelLoadLaserdiscCatsBench.parallelLoad1           thrpt  200   5566.682 ±  25.381  ops/s
ParallelLoadLaserdiscCatsBench.parallelLoad2           thrpt  200  13446.380 ±  35.670  ops/s
ParallelLoadLaserdiscCatsRespBench.parallelLoad1       thrpt  200   5823.357 ±  56.710  ops/s
ParallelLoadLaserdiscCatsRespBench.parallelLoad2       thrpt  200  10238.087 ±  55.337  ops/s
ParallelLoadLaserdiscCatsBitVectorBench.parallelLoad1  thrpt  200   7082.593 ±  31.425  ops/s
ParallelLoadLaserdiscCatsBitVectorBench.parallelLoad2  thrpt  200  11236.398 ± 132.632  ops/s
ParallelLoadLaserdiscCatsByteBench.parallelLoad1       thrpt  200  48415.228 ± 189.814  ops/s
ParallelLoadLaserdiscCatsByteBench.parallelLoad2       thrpt  200  52288.273 ± 176.331  ops/s
ParallelLoadLaserdiscCatsBaselineBench.parallelLoad1   thrpt  200  49319.429 ± 387.479  ops/s
ParallelLoadLaserdiscCatsBaselineBench.parallelLoad2   thrpt  200  52857.024 ± 163.238  ops/s
Total time: 28030 s (07:47:10), completed 03-Aug-2020 08:03:43

Copy link
Member

@sirocchj sirocchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This jump looks indeed suspicious...

ParallelLoadLaserdiscCatsBitVectorBench.parallelLoad2  thrpt  200  11236.398 ± 132.632  ops/s
ParallelLoadLaserdiscCatsByteBench.parallelLoad2       thrpt  200  52288.273 ± 176.331  ops/s

I could not spot anything - good to merge!
Btw... outstanding

@barambani barambani merged commit 2c223c3 into laserdisc-io:master Aug 5, 2020
@barambani barambani deleted the parallel-bench-cases branch August 5, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants