-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pashto language localization #310
Conversation
is exist there any issues? |
I appreciate you adding the Pashto language localization. In your code, the ps language should appear right after the nl language to keep them alphabetized. |
@@ -14,6 +17,7 @@ stream is updated each time the app resumes from the background. | |||
- Added support for checking for updates every time the app resumes from the background. (#272) | |||
- Changed the way Upgrader is initialized to support a stream of evaluation requests. The | |||
stream is updated each time the app resumes from the background. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this change for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my IDE's automatic changes.
@@ -86,7 +90,7 @@ stream is updated each time the app resumes from the background. | |||
## 5.1.0 | |||
|
|||
- Updated the initialization of upgrader to use a future that will allow the initialize method to be called multiple times. This | |||
does not require any changes by app code. | |||
does not require any changes by app code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this change for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my IDE's automatic changes.
@@ -96,7 +100,7 @@ does not require any changes by app code. | |||
## 5.1.0-alpha.1 | |||
|
|||
- Updated the initialization of upgrader to use a future that will allow the initialize method to be called multiple times. This | |||
does not require any changes by app code. | |||
does not require any changes by app code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this change for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my IDE's automatic changes.
@@ -120,31 +124,31 @@ does not require any changes by app code. | |||
## 4.11.0 | |||
|
|||
- Updated package dependencies: | |||
- mockito to ">=5.0.0 <5.4.0" | |||
- mockito to ">=5.0.0 <5.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this change for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my IDE's automatic changes.
- package_info_plus to ">=1.3.0 <3.0.0" | ||
- shared_preferences to ">=2.0.3 <2.1.0" | ||
- url_launcher to ">=6.1.0 <= 6.1.5" | ||
- device_info_plus to ">=3.2.0 <7.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this change for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my IDE's automatic changes.
Also, please include the upgrader version number from the pubspec.lock file, which should look something like this: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this change for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my IDE's automatic changes.
@isshort If you would like this PR to be merged, you first need to address the comments and the merge conflict. |
@isshort Any update on this? |
@larryaasen I apologize for the delayed response. The remaining changes were automatically made by my IDE. |
@isshort I can't merge this PR until you address the comments in this PR. |
@isshort I cannot merge this PR unless the random file changes are removed. |
Okay I'll fix it asap. |
Closed due to inactivity. |
Added Pashto language localization.