fix boolean data type issue for Pojoutils.java#getDefaultValue

larryDltake · Nov 12, 2020 · b14e534 · b14e534
1 parent 4a265a5
commit b14e534
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/PojoUtils.java b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/PojoUtils.java
@@ -607,7 +607,7 @@ private static Object getDefaultValue(Class<?> parameterType) {
         if ("char".equals(parameterType.getName())) {
             return Character.MIN_VALUE;
         }
-        if ("bool".equals(parameterType.getName())) {
+        if ("boolean".equals(parameterType.getName())) {
             return false;
         }
         return parameterType.isPrimitive() ? 0 : null;

diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/model/SerializablePerson.java b/dubbo-common/src/test/java/org/apache/dubbo/common/model/SerializablePerson.java
@@ -27,6 +27,9 @@ public class SerializablePerson implements Serializable {
 
     private String[] value = {"value1", "value2"};
 
+    public SerializablePerson(char description , boolean adult){
+
+    }
     public String getName() {
         return name;
     }
@@ -94,4 +97,4 @@ public boolean equals(Object obj) {
             return false;
         return true;
     }
-}
+}
diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/utils/PojoUtilsTest.java b/dubbo-common/src/test/java/org/apache/dubbo/common/utils/PojoUtilsTest.java
@@ -133,7 +133,7 @@ public void test_primitive() throws Exception {
     @Test
     public void test_pojo() throws Exception {
         assertObject(new Person());
-        assertObject(new SerializablePerson());
+        assertObject(new SerializablePerson(Character.MIN_VALUE, false));
     }
 
     @Test
@@ -147,7 +147,7 @@ public void test_Map_List_pojo() throws Exception {
 
         List<Object> list = new ArrayList<Object>();
         list.add(new Person());
-        list.add(new SerializablePerson());
+        list.add(new SerializablePerson(Character.MIN_VALUE, false));
 
         map.put("k", list);
 
@@ -901,4 +901,4 @@ interface Message {
 
         boolean isUrgent();
     }
-}
+}