Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __all__ to __init__ #1200

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Add __all__ to __init__ #1200

merged 1 commit into from
Oct 27, 2022

Conversation

aspizu
Copy link
Contributor

@aspizu aspizu commented Oct 14, 2022

No description provided.

@aspizu aspizu changed the title Closes #1199, Add __all__ to __init__ Add __all__ to __init__ Oct 14, 2022
@erezsh erezsh requested a review from MegaIng October 15, 2022 06:29
MegaIng
MegaIng approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@MegaIng MegaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally find this __all__ definition unnecessary, but if it silents type checkers, oh well

@aspizu
Copy link
Contributor Author

aspizu commented Oct 18, 2022

https://stackoverflow.com/questions/44834/what-does-all-mean-in-python

@erezsh
Copy link
Member

erezsh commented Oct 18, 2022

@MegaIng I agree, it's quite superfluous, but at the same time it seems to help, and I have no serious objection against it.

@erezsh erezsh merged commit 6365160 into lark-parser:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaIng MegaIng MegaIng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aspizu @erezsh @MegaIng