specify ignored mypy error by using type: ignore[error] in lark/tree.py and lark/utils.py
#1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of plain ignore
hf-kklein
changed the title
type: ignore[error]type: ignore[error] in lark/tree.py
hf-kklein
changed the title
type: ignore[error] in lark/tree.pytype: ignore[error] in lark/tree.py and lark/utils.py
|
Just curious, what is the benefit of this change? |
IMHO it's always better to only ignore specific linter warnings; In the same manner as it's always better to catch specific errors instead of a catch all/broad except. |
|
Well, I guess. It's a little different with exceptions though, since they can jump out of nested functions. Whereas here the "catcher" is tied directly to the line itself. |
erezsh
approved these changes
Feb 8, 2022
MegaIng
reviewed
Feb 8, 2022
|
I have. I'll wait to see what he thinks. (though it's probably a non-issue) |
he uses the same style already ;) Line 466 in c780b3b |
|
Fair enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of plain ignore