Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use __name__ in FromPackageLoader in test_grammar.py #1049

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Use __name__ in FromPackageLoader in test_grammar.py #1049

merged 1 commit into from
Dec 8, 2021

Conversation

pfhayes
Copy link
Contributor

@pfhayes pfhayes commented Dec 8, 2021

This is the recommended way to call FromPackageLoader from its docs, and makes running the tests a bit more portable

@pfhayes
Use __name__ in FromPackageLoader in test_grammar.py
5de2ae1 
This is the recommended way to call FromPackageLoader from its docs, and makes running the tests a bit more portable
MegaIng
MegaIng approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@MegaIng MegaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, this slipped through when originally implementing this. I thought this was changed later on to fix tests failing in in some situations, but that is apparently not the case.

@erezsh erezsh merged commit 8c89670 into lark-parser:master Dec 8, 2021
@pfhayes pfhayes deleted the patch-1 branch December 8, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaIng MegaIng MegaIng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pfhayes @MegaIng @erezsh