A bit of cleanup, improve test coverage #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaIng
suggested changes
Oct 19, 2021
| else: | ||
| titem = TransitiveItem(origin, trule, originator, start) | ||
| previous = transitives[start][origin] = titem | ||
| # def create_leo_transitives(origin, start): |
There was a problem hiding this comment.
Why leave it as a comment? If we need it later, we still have git history
There was a problem hiding this comment.
We'll probably forget it even exists..
Now it's almost like a TODO. But perhaps I can replace it with a TODO and a git-ref
| before = ( expansion.name for expansion in self.rule.expansion[:self.ptr] ) | ||
| after = ( expansion.name for expansion in self.rule.expansion[self.ptr:] ) | ||
| return '{} : {} -> {}* {} ({}, {})'.format(self.recognized.name, self.rule.origin.name, ' '.join(before), ' '.join(after), self.column, self.start) | ||
| # class TransitiveItem(Item): |
MegaIng
approved these changes
Oct 19, 2021
Codecov Report
@@ Coverage Diff @@
## master #1020 +/- ##
==========================================
+ Coverage 87.11% 87.77% +0.65%
==========================================
Files 50 50
Lines 7208 7155 -53
==========================================
+ Hits 6279 6280 +1
+ Misses 929 875 -54
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure there's anything to review, but just in case.