Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds icons to navigation dropdown #953

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Conversation

ProjektGopher
Copy link
Contributor

@ProjektGopher ProjektGopher commented Jul 27, 2023

Resolves #952
Screenshot 2023-07-27 at 9 42 20 AM

@driesvints
Copy link
Member

driesvints commented Jul 28, 2023

Very cool! Thanks @ProjektGopher

I'm just wondering if we could vertical align the icons and text a little better? I think that can be done with flexbox on each anchor tag but not 100% sure.

@driesvints driesvints changed the title [ Feat ] Adds icons to navigation dropdown Adds icons to navigation dropdown Jul 28, 2023
@joedixon
Copy link
Contributor

Thanks @ProjektGopher! As @driesvints mentioned, you should be able to vertically align the icons and text with the follwing (though not sure if removing the inline-block may cause a different issue):

- <a href="{{ route('profile') }}" class="inline-block w-full lg:px-4 lg:py-3">
+ <a href="{{ route('profile') }}" class="flex items-center w-full lg:px-4 lg:py-3">
    <x-heroicon-o-user class="w-4 h-4 inline mr-1" />
    Your Profile
</a>

@ProjektGopher

This comment was marked as outdated.

@ProjektGopher
Copy link
Contributor Author

@driesvints @joedixon I had five mins before taking my daughter to daycare - here it is

Screenshot 2023-07-28 at 10 01 14 AM

@driesvints
Copy link
Member

Perfect thanks! I changed the admin one to a shield instead.

@driesvints driesvints merged commit 6c88510 into laravelio:main Jul 28, 2023
1 check passed
@ProjektGopher ProjektGopher deleted the icons branch July 28, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add icons before menu items in dropdown
3 participants