Skip to content

[2.x] Add HtmlString caster #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

[2.x] Add HtmlString caster #87

merged 1 commit into from
Jan 10, 2020

Conversation

GrahamCampbell
Copy link
Member

Before:

>>> Illuminate\Mail\Markdown::parse("### test\n");
=> Illuminate\Support\HtmlString {#3811}

After:

>>> Illuminate\Mail\Markdown::parse("### test\n");
=> Illuminate\Support\HtmlString {#4008
     html: "<h3>test</h3>\n",
   }

driesvints
driesvints approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@taylorotwell taylorotwell merged commit 512bd79 into 2.x Jan 10, 2020
@GrahamCampbell GrahamCampbell deleted the html-string-cast branch January 10, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrahamCampbell @driesvints @taylorotwell