[2.x] Updated actions config #108
Conversation
| run: composer require "illuminate/contracts=${{ matrix.laravel }}" --prefer-dist --no-interaction | ||
| run: | | ||
| composer require "illuminate/contracts=${{ matrix.laravel }}" --no-update | ||
| composer update --prefer-dist --no-interaction --no-progress |
There was a problem hiding this comment.
This isn't necessary for this repo. Can you revert this?
There was a problem hiding this comment.
Yes, this is necessary, and I can't revert. See the first commit I tried where the tests failed.
|
I think it's best that we wait until a stable composer 2 version lands and becomes the new default. Otherwise we'll be update all repos again soon to remove the "2" indicator. Tests are running fast enough for now. |
Actually, the tests will break when composer 2 becomes the default (because of the changes needed to the install step), so this PR is a proactive fix. |
|
@GrahamCampbell so composer 2 will break all apps/servers that auto update composer? |
|
No. Most apps don't do a require without there already being a lock file present. That is what is not supported. You must ask for either no-update, or already have a lock file. |
|
What I am talking about is this:
|
|
Gotcha. I'll try to look into this some more next week. |
|
Perfect. :) |
To be the same as the framework repos.