Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the custom Avatar callback, we ran into issues with the newest version of Telescope. See #1579
Issue
Since version v5.6.0, it is possible to get a nullable
$id
and nullable$email
. Which comes with unexpected behaviour compared to what the Laravel docs show.Solution
As far as i have found the moment the users object is null in the payload the UI does not show information about the user. So the idea behind this fix is to disallow nullable
$id
and return before any callback is triggerd.while keeping the requested feature added in #1565
Once this is merged, I'll also create a pull request to update the Laravel docs to reflect this.
Let me know if any additional changes are need! 😊