Feat: Laravel-friendly model lookup #949
Closed
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
Also, this may warrant a docs update |
|
Can re-submit this without the one-line stuff? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR allows users to type commands such as
php artisan scout:import Userinstead ofphp artisan scout:import "App\\Models\\User"by doing a quick lookup if the user's input is not immediately found.It seems more in-line with other Artisan CLI commands from Laravel without breaking existing functionality.
I'm not sure if the PHPDoc
@throwstag is wanted or not - PHPStorm suggested it after adding a throw. I did need to update the test, since it was excepting anErrorclass and we now pass a ScoutException, which seems more appropriate in this situation and should be easier for a dev to debug since these commands run within CI/CD, forge deploy scripts, crons, etc.