Handle empty whereIn clause #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Algolia and Meilisearch engines currently do not handle empty
whereInclauses correctly. Algolia seems to ignore it whereas Meilisearch gives an error. This pull request aims to resolve this.Algolia
I've copied the fix that was included in algolia/scout-extended where they just send
0=1.https://github.com/algolia/scout-extended/pull/265/files
Meilisearch
I've used the
INoperator that was introduced in Meilisearch v0.29:meilisearch/product#407 (comment)
This automatically handles the empty case and is a more elegant way of doing it instead of the
ORoperator.