Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Overridable jobs #476

Merged
merged 8 commits into from
Jun 1, 2021
Merged

Conversation

MatanYadaev
Copy link
Contributor

This PR makes the package's jobs open for extension, for users that want to adjust the $tries, $backoff, $maxExceptions properties.

I implemented the same approach that implemented on Laravel Sanctum, providing the user the freedom the choose which job class will be used in the config file.

Discussed in #474.

config/scout.php Outdated Show resolved Hide resolved
@driesvints driesvints marked this pull request as draft June 1, 2021 14:16
@driesvints driesvints changed the title Overridable jobs [9.x] Overridable jobs Jun 1, 2021
@driesvints
Copy link
Member

Putting this in draft for now. Can you make the changes I requested?

@MatanYadaev
Copy link
Contributor Author

@driesvints Sure, thanks for the review and comment. It looks good now?
I wasn't sure if the tests are good or redundant, WDYT?

@driesvints
Copy link
Member

If you fix the StyleCI warning and remove the two tests I highlighted I think we're good.

@MatanYadaev
Copy link
Contributor Author

@driesvints I didn't use StyleCI before. I need to register and configure an API key, right? Currently, the StyleCI website doesn't work for me so I can't do it locally.
There isn't a CI job for this?

@MatanYadaev
Copy link
Contributor Author

@driesvints Yes, the page doesn't work for me. Reported it to Graham on Twitter.

@driesvints driesvints marked this pull request as ready for review June 1, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants