Skip to content

Commit

Permalink
fix(typesense): remove builder limit assignment on paginate (#858)
Browse files Browse the repository at this point in the history
- Remove assignment of `perPage` to builder's limit attribute
- Allows for accurate total record count beyond `perPage` value
- Addresses interaction issue between `Builder` and `TypesenseEngine`
- Ensures correct limit setting for Typesense server queries
  • Loading branch information
tharropoulos authored Sep 4, 2024
1 parent 2d3131a commit 71502b1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/Engines/TypesenseEngine.php
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,6 @@ public function search(Builder $builder)
*/
public function paginate(Builder $builder, $perPage, $page)
{
$builder->take($builder->limit ?? $perPage);

return $this->performSearch(
$builder,
$this->buildSearchParameters($builder, $page, $perPage)
Expand Down

0 comments on commit 71502b1

Please sign in to comment.