Skip to content

Conversation

@onlime
Copy link
Contributor

@onlime onlime commented Mar 30, 2025

In Laravel v12.4.0 laravel/framework#55011, the following method was added to Illuminate\Database\Migrations\Migration:

    public function shouldRun(): bool
    {
        return true;
    }

so Laravel v12.4.0 breaks Pulse:

  In PulseMigration.php line 25:                                                                                                                                     
                                                                                                                                                                     
    Access level to Laravel\Pulse\Support\PulseMigration::shouldRun() must be public (as in class Illuminate\Database\Migrations\Migration)                              

This PR fixes it.

@tobya
Copy link

tobya commented Mar 30, 2025

I had this issue also.

I think your PR description should say that function shouldRun() was added rather than function getConnection()

@onlime
Copy link
Contributor Author

onlime commented Mar 30, 2025

I think your PR description should say that function shouldRun() was added rather than function getConnection()

oh, yes, thx. Fixed in the description.

@taylorotwell taylorotwell merged commit b3cf86e into laravel:1.x Mar 30, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants