Fix output of escape characters when using NullOutput
interface
#28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when the output interface has been set to a
NullOutput
instance (e.g. when using thecallSilent
method in Laravel).Currently, cursor manipulation and erase escape sequences are written directly to STDOUT because they interfere with the trailing newline calculation. However, when a
NullOutput
instance is used, the escape sequences are still output while the rest of the output is dropped.When using Laravel's
OutputStyle
, we can bypass its newline calculation by writing directly to the underlyingOutputInterface
using thegetOutput
method.When used without Laravel, I've added a
writeDirectly
method to theConsoleOutput
class that bypasses the calculation.This partially solves #22, but a framework PR is required to completely solve it.