[7.0] Change wasRecentlyCreated to false #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
|
Please include the exact conditional check that is in the framework. |
The core framework fixed this same bug with the core actingAs method but it seems it was missed for Passport! Check this PR for more details: laravel/framework#25873
|
@taylorotwell Done! Did I miss something about how this conditional works or is this a consistency thing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting with explanation as requested by @driesvints in #975
The core framework fixed this same bug with the core actingAs method but
it seems it was missed for Passport! Check this PR for more details:
laravel/framework#25873
I don't think we need the conditional, and certainly not the truthy check of it on the right side. Setting something to false that's already false won't have any negative effects. The
Userthat's passed to the auth guard is expecting anAuthenticatablewhich also extendsModel, which should always havewasRecentlyCreated.I look at this as "Hey look we need this to be false, why do we care if it's true first?"