Skip to content

fix: possible php error if redirect column is an empty string #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

Tofandel
Copy link
Contributor

@Tofandel Tofandel commented May 27, 2025

image

@hafezdivandari
Copy link
Contributor

This actually never happens, the redirect_uris column (if exists) is always a json array (may be emtpy []) but never null or '' unless you have manipulated the table manually, if so I suggest to have default value of [] for your previouse records instead of this PR.

@Tofandel
Copy link
Contributor Author

Tofandel commented May 27, 2025

This actually never happens
unless you have manipulated the table manually

So it can happen :) especially after a migration

This is just a very basic sanity check

@taylorotwell taylorotwell merged commit 01aaf7d into laravel:13.x May 27, 2025
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants