[13.x] Fix middleware type error #1815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passport's changed middleware incorrectly assumes
OAuthenticatable::currentAccessToken()
returns an instance ofAccessToken
, when it actually returns any implementation ofScopeAuthorizable
(which includesTransientToken
). This PR fixes theTypeError
that arises when the user has a token set that is not of typeAccessToken
.Note that this is a potential breaking change for anyone that is extending the middleware on 13.0.0 (which is probably not many people since its not been out for long). However, I don't see any other way to fix this
TypeError
and not fixing this means you'd have to use your own middleware if you wanted to useTransientToken
or a custom token implementation