Infinite loop, stack overflow

[iget-master]

Hi,

I have two projects, both using L5.5 and latest Laravel Passport.

Both projects runs under a docker environment, but the first one works, the last don't.
Actually, both worked, but after some permission changes (my docker env was setting 777 for everything), it stopped working, but only one of them.

I've tried to revert the changes, clear install the environment, with no success.

The failing project just gives me 500 error, with exceeded execution time (30s).

Looking the logs, I've found the following log, see the bin, only for the last 3 entries, but the entire file grows very fast to 1GB.

Observe that this part repeats a lot of times, indicating an infinite loop:

#16 [internal function]: Laravel\Passport\PassportServiceProvider->Laravel\Passport\{closure}(Object(Illuminate\Http\Request), NULL)
#17 /var/www/vendor/laravel/framework/src/Illuminate/Auth/RequestGuard.php(58): call_user_func(Object(Closure), Object(Illuminate\Http\Request), NULL)
#18 /var/www/vendor/laravel/framework/src/Illuminate/Auth/GuardHelpers.php(70): Illuminate\Auth\RequestGuard->user()
#19 /var/www/vendor/laravel/framework/src/Illuminate/Auth/AuthManager.php(292): Illuminate\Auth\RequestGuard->id()
#20 /var/www/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php(221): Illuminate\Auth\AuthManager->__call('id', Array)
#21 /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php(152): Illuminate\Support\Facades\Facade::__callStatic('id', Array)
#22 /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php(113): Illuminate\Foundation\Exceptions\Handler->context()
#23 /var/www/app/Exceptions/Handler.php(43): Illuminate\Foundation\Exceptions\Handler->report(Object(League\OAuth2\Server\Exception\OAuthServerException))
#24 /var/www/vendor/laravel/passport/src/Guards/TokenGuard.php(143): App\Exceptions\Handler->report(Object(League\OAuth2\Server\Exception\OAuthServerException))
#25 /var/www/vendor/laravel/passport/src/Guards/TokenGuard.php(90): Laravel\Passport\Guards\TokenGuard->authenticateViaBearerToken(Object(Illuminate\Http\Request))
#26 /var/www/vendor/laravel/passport/src/PassportServiceProvider.php(267): Laravel\Passport\Guards\TokenGuard->user(Object(Illuminate\Http\Request))
#27 [internal function]: Laravel\Passport\PassportServiceProvider->Laravel\Passport\{closure}(Object(Illuminate\Http\Request), NULL)

Since the issue is a little complex, I'm able to provide some necessary information that you need.

[iget-master]

Investigating the issue, I've found that this line causes the problem:

https://github.com/laravel/framework/blob/ac2c64ec61192771b106215296e6322a09221974/src/Illuminate/Foundation/Exceptions/Handler.php#L152

Not sure yet if it's a framework's issue or passport.

Commenting out this line, the infinite loop disappear, although another error is thrown since I removed a parameter to the subsequent function call. Still investigating.

---

The cycle is: The auth middleware try to authenticate, fail due some passport/oauth2 error that I didn't discovered yet (edit: the error is simple, the bearer token used on the request isn't valid anymore) (the message on the exception that causes the loop is: "The resource owner or authorization server denied the request."), when the error Handler class try to report, it calls again the Guard to ask for the authenticated user, then the loop begins.

Probably the Passport guard should keep some flag to indicate that it have failed, avoiding this loop.

[iget-master]

@nmfzone could you submit a PR if you think that your commit fixes this?

[nmfzone]

@iget-master I've submit a PR, but unfortunately got rejected. See #654

[cmmarslender]

The fix for this introduced a new bug #668 - Created a PR that fixes the new bug ( #669 )