Don't show the delete button when clicking "Select all matching"

[cord]

• Laravel Version: 7
• Nova Version: 3.15
• PHP Version: 7.4

Reposted from #322

Description:

The "Delete selected" option is shown when clicking "Select all matching" in the resource index, even when the user is actually not allowed to delete anything (see images below).

Detailed steps to reproduce the issue on a fresh Nova installation:

Set up a Resource with disabling Delete:

    public function authorizedToDelete(Request $request)
    {
        return false;
    }

use the select drop down to reproduce the behaviour

[crynobone]

There no way to guarantee that all record will return false; without querying every records. Imagine if you have 500,000 records for the resource and we need to verify each one to disable the Delete button.

[davidhemphill]

👋 Hi there! In order to keep this repository focused on bug reports, we auto-close feature requests and requests for help. Feel free to post your feature requests so others can discuss and add reactions. We'll keep an eye on them for later planning.

[cord]

There no way to guarantee that all record will return false; without querying every records. Imagine if you have 500,000 records for the resource and we need to verify each one to disable the Delete button.

I suggest introducing settings on resource level to control the select/select all/ delete features - so for read only resource we can use a setting to disable the delete button.

[dmason30]

@crynobone perhaps introduce deleteAny / forceDeleteAny / restoreAny policy methods which works similar to viewAny and only takes in the authorised user and if return false then hide the delete dropdown.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.