Capture scheduled task sub-minute frequency #302
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
commented
Nov 19, 2025
Comment on lines
+61
to
+63
| '_group' => $repeatSeconds > 0 | ||
| ? hash('xxh128', "{$name},{$event->task->expression},{$timezone},{$repeatSeconds}") | ||
| : hash('xxh128', "{$name},{$event->task->expression},{$timezone}"), |
Member
Author
There was a problem hiding this comment.
This will mean that existing sub-minute tasks will end up with a new group and appear duplicated until the old ones fall out of range. The newer records will appear different because they will display the sub-minute frequency, while the older records will still appear as though they are not sub-minute.
The alternative is to continue not include the repeat seconds in the group, but that would mean separate tasks would get grouped together if the same task has a subminute frequency and a non-subminute frequency that is otherwise the same, which is unlikely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.