Skip to content

[8.x] Fixed DocBlocks #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/Concerns/RoutesRequests.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ trait RoutesRequests
/**
* Add new middleware to the application.
*
* @param Closure|array $middleware
* @param \Closure|array $middleware
* @return $this
*/
public function middleware($middleware)
Expand Down Expand Up @@ -85,7 +85,10 @@ public function routeMiddleware(array $middleware)
}

/**
* {@inheritdoc}
* Dispatch request and return response.
*
* @param \Symfony\Component\HttpFoundation\Request $request
* @return \Illuminate\Http\Response
*/
public function handle(SymfonyRequest $request)
{
Expand All @@ -101,7 +104,7 @@ public function handle(SymfonyRequest $request)
/**
* Run the application and send the response.
*
* @param SymfonyRequest|null $request
* @param \Symfony\Component\HttpFoundation\Request|null $request
* @return void
*/
public function run($request = null)
Expand Down Expand Up @@ -149,8 +152,8 @@ protected function callTerminableMiddleware($response)
/**
* Dispatch the incoming request.
*
* @param SymfonyRequest|null $request
* @return Response
* @param \Symfony\Component\HttpFoundation\Request|null $request
* @return \Illuminate\Http\Response
*/
public function dispatch($request = null)
{
Expand Down Expand Up @@ -195,7 +198,7 @@ protected function parseIncomingRequest($request)
/**
* Create a FastRoute dispatcher instance for the application.
*
* @return Dispatcher
* @return \FastRoute\Dispatcher
*/
protected function createDispatcher()
{
Expand Down Expand Up @@ -393,7 +396,7 @@ protected function callControllerCallable(callable $callable, array $parameters
/**
* Gather the full class names for the middleware short-cut string.
*
* @param string $middleware
* @param string|array $middleware
* @return array
*/
protected function gatherMiddlewareClassNames($middleware)
Expand Down Expand Up @@ -430,7 +433,7 @@ protected function sendThroughPipeline(array $middleware, Closure $then)
* Prepare the response for sending.
*
* @param mixed $response
* @return Response
* @return \Illuminate\Http\Response
*/
public function prepareResponse($response)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Http/Redirector.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ class Redirector
/**
* The application instance.
*
* @var Application
* @var \Laravel\Lumen\Application
*/
protected $app;

/**
* Create a new redirector instance.
*
* @param Application $app
* @param \Laravel\Lumen\Application $app
* @return void
*/
public function __construct(Application $app)
Expand Down
15 changes: 11 additions & 4 deletions src/Routing/ProvidesConvenienceMethods.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public static function formatErrorsUsing(BaseClosure $callback)
* @param array $customAttributes
* @return array
*
* @throws ValidationException
* @throws \Illuminate\Validation\ValidationException
*/
public function validate(Request $request, array $rules, array $messages = [], array $customAttributes = [])
{
Expand Down Expand Up @@ -92,7 +92,7 @@ protected function extractInputFromRules(Request $request, array $rules)
* @param \Illuminate\Contracts\Validation\Validator $validator
* @return void
*
* @throws ValidationException
* @throws \Illuminate\Validation\ValidationException
*/
protected function throwValidationException(Request $request, $validator)
{
Expand All @@ -102,7 +102,11 @@ protected function throwValidationException(Request $request, $validator)
}

/**
* {@inheritdoc}
* Build a response based on the given errors.
*
* @param \Illuminate\Http\Request $request
* @param array $errors
* @return \Illuminate\Http\JsonResponse|mixed
*/
protected function buildFailedValidationResponse(Request $request, array $errors)
{
Expand All @@ -114,7 +118,10 @@ protected function buildFailedValidationResponse(Request $request, array $errors
}

/**
* {@inheritdoc}
* Format validation errors.
*
* @param \Illuminate\Validation\Validator $validator
* @return array|mixed
*/
protected function formatValidationErrors(Validator $validator)
{
Expand Down