Tiny inconsistency between 'between' and 'digits_between' validation rules messages #2377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The dash doesn't feel like correct English to me. If there's a "between", there should be an "and". You can send a pull request for this. =) |
taylorotwell
added a commit
that referenced
this pull request
Oct 29, 2013
Tiny inconsistency between 'between' and 'digits_between' validation rules messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though
betweenanddigits_betweenvalidation rules are pretty much the same, they do have a small difference:betweenuses-for the range, whiledigits_betweenusesand.between:
The :attribute must be between :min - :max.digits_between:
The :attribute must be between :min and :max digits.I know this is really no big deal, but it does look nonconforming when you look at both errors side by side, on your website. I was thinking maybe we could decide which is better and just change the other.