Fixed a button spacing issue in dialog modal footer. #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you share before / after on desktop as well? |
|
Sure, You can see it in below screenshots. BeforeAfter |
|
@taylorotwell Do you want this change in confirmation-modal too? This issue can happen on that modal too if developer using it use big button name like this. Also, I notice there was a little bit of change in spacing between buttons so It should be good idea to increase the margin from ml-2 to ml-3 to match the spacing before this modification. Let me know if you want this change so I can open a pull request. |
taylorotwell
pushed a commit
that referenced
this pull request
Dec 30, 2021
* Fixed button spacing issue in dialog modal footer. * Modified confirmation-modal to avoid button spacing issue and increased margin to ml-3 on second button to match the spacing before this modification. * Applied fix to Inertia version too.
GeoSot
pushed a commit
to GeoSot/jetstream
that referenced
this pull request
Jan 27, 2022
GeoSot
pushed a commit
to GeoSot/jetstream
that referenced
this pull request
Jan 27, 2022
* Fixed button spacing issue in dialog modal footer. * Modified confirmation-modal to avoid button spacing issue and increased margin to ml-3 on second button to match the spacing before this modification. * Applied fix to Inertia version too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a button spacing issue in dialog modal footer.
Before
After