Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KeyboardEvent key attribute for Escape #911

Merged
merged 1 commit into from
Nov 30, 2021
+1 −1
Merged

Use KeyboardEvent key attribute for Escape #911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use KeyboardEvent key attribute for Escape 
Use KeyboardEvent `key` attribute for Escape instead of deprecated `keyCode`.

See https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode
  • Loading branch information
@LeoColomb
LeoColomb authored Nov 30, 2021
commit 42100320722842568c187b59a0529c573c5f0709
2 changes: 1 addition & 1 deletion stubs/inertia/resources/js/Jetstream/Dropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default defineComponent({
let open = ref(false)

const closeOnEscape = (e) => {
if (open.value && e.keyCode === 27) {
if (open.value && e.key === 'Escape') {
open.value = false
}
}
Expand Down