[2.x] Inertia - ensure file selection is not empty before updating profile photo preview #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While selecting a new profile photo, canceling the file selection window results in errors being displayed in the console saying,
Failed to execute 'readAsDataURL' on 'FileReader': parameter 1 is not of type 'Blob'.Video demonstration
For some reason, the
@change="updatePhotoPreview"method is being triggered although no changes were made to the input. Possibly a Vue related issue since this doesn't happen in the Livewire stack?Probably worth noting that I've run into this issue on Windows and specifically Chromium based browsers.
Steps to reproduce