-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Delete the users profile picture #399
Conversation
delete the users profile image
delete the users profile picture
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could check if the Feature is enabled before, so no errors if it's not enabled
Co-authored-by: Claudio Dekker <1752195+claudiodekker@users.noreply.github.com>
Co-authored-by: Claudio Dekker <1752195+claudiodekker@users.noreply.github.com>
Co-authored-by: Claudio Dekker <1752195+claudiodekker@users.noreply.github.com>
Personally I would move that feature check into the |
Looks like tests are failing... |
@taylorotwell adjusted, guess that's the way you meant? The test now fails because the tests\Fixture\User.php doesnt have the jetstream/tests/Fixtures/User.php Line 11 in e37dbff
|
You can add it to the fixture. Yes that looks fine. Thanks. |
When a user deletes an account, the image will now be deleted as well. fixes #396