Skip to content

Replace "ml-*" to "mx-*" whenever possible for better support for both LTR/RTL languages, and avoid text-align attributes #363

@MuhammedAlkhudiry

Description

@MuhammedAlkhudiry
  • Jetstream Version: 1.4.0
  • Jetstream Stack: Inertia / Livewire
  • Laravel Version: 8.0.0
  • PHP Version: 7.4.0
  • Database Driver & Version:
    mysql

Description:

In the default views, there are many uses of "ml-" for spacing between elements that can be replaced safely to "mx-" which better since it has the same effect for both "direction: rtl" and "direction: ltr"

The same can be said for padding.

Also, text-align should be avoided whenever possible, since the direction style can take care of the text direction.
Example:

لقطة الشاشة 2020-10-19 133253

  • Using "text-left" caused a problem for "logout" when using "direction: rtl", although "profile" is working without text-align

Steps To Reproduce:

Any fresh installment of Jetstream with either Inertia/Livewire.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions