Add support for Yarn, PNPM, and Bun in Laravel Installer for better package manager control #440
+40
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackage manager control Thanks to the amazing PR laravel#439 by @ludo237 , I’d like to suggest a slightly different approach to selecting the package manager, allowing developers to choose it in a more explicit and flexible way. This PR introduces support for Yarn, PNPM, and Bun alongside npm in the Laravel Installer. Developers can now select their preferred package manager via CLI options or an interactive prompt, or skip installation of JS packages entirely. This approach gives developers direct control over which package manager to use, instead of relying solely on lock file detection (as in the related PR). It improves flexibility while maintaining backward compatibility with npm as the default.
roberto-butti
changed the title
ludo237
reviewed
Oct 9, 2025
| } | ||
|
|
||
| if ($runNpm) { | ||
| if ($selectedPackageManager === 'skip' || ! $selectedPackageManager) { |
There was a problem hiding this comment.
small proposal
$shouldRunPackageManager = true;
if ($selectedPackageManager === 'skip' || ! $selectedPackageManager) {
$shouldRunPackageManager = false;
$selectedPackageManager = 'npm';
}
|
I don't really want another prompt for this during the install process. NPM is fine to get started - people can switch to whatever they want after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the amazing PR #439 by @ludo237 , I’d like to suggest a slightly different approach to selecting the package manager, allowing developers to choose it in a more explicit and flexible way.
This PR introduces support for Yarn, PNPM, and Bun alongside npm in the Laravel Installer. Developers can now select their preferred package manager via CLI options or an interactive prompt, or skip installation of JS packages entirely.
This approach gives developers direct control over which package manager to use, instead of relying solely on lock file detection (as in the related PR). It improves flexibility while maintaining backward compatibility with npm as the default.