[Proposal] Make dependency injection work with default values #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $container = new Container; | ||
| $container->bind('IContainerContractStub', 'ContainerImplementationStub'); | ||
| $class = $container->make('ContainerNestedDependentWithDefaultValueStub'); | ||
| $this->assertTrue($class->inner instanceof ContainerDependentStub); |
There was a problem hiding this comment.
How about assertInstanceOf()?
There was a problem hiding this comment.
I was just copying Taylors tests
|
Nice one. Looks good. |
| $this->inner = $inner; | ||
| $this->innerArray = $innerArray; | ||
| $this->innerString = 'string'; |
There was a problem hiding this comment.
This is supposed to copy over the parameter?
There was a problem hiding this comment.
No, oops. Half asleep here haha
|
Seems logical to me. 👍 |
|
Are these being checked? |
|
Worked for me 👍 |
|
Done. Implemented slightly differently. |
joelharkes
pushed a commit
to joelharkes/framework_old
that referenced
this pull request
Mar 7, 2019
Feature/create users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this would work by default, was using a component via dependency injection that has
$configuration = nullin the constructor and it threw the binding resolution exception. So I had a look and it was easy to make default values work, is there any reason to not do this?