[4.2] Correctly fill the $request->request parameter bag on creation

[hannesvdvreken]

The Illuminate\Http\Request class extends the Symfony\Component\HttpFoundation\Request. But the SymfonyRequest does not fill the property ->request (which should hold the POST parameters), except when the Content-Type header is equal to application/x-www-form-urlencoded (see source).

IlluminateRequest parses the request body if the Content-Type header is set to application/json, but only when the getInputSource() method is called. In Laravel you can request the IlluminateRequest and pass it on, but when the IlluminateRequest is used using the SymfonyRequest interface, and they access the ->request ParameterBag, it will not be loaded with the request body data if it's json formatted.

[taylorotwell]

Can you describe the bug?

[taylorotwell]

Also a test would be nice. Thanks :)

[hannesvdvreken]

The bug is described in the description. I'll add a test later today.

[GrahamCampbell]

Please do not rename this variable.

[hannesvdvreken]

Updated.

[taylorotwell]

Can you describe how this actually effects applications? What could you not do before that this fixes?

[hannesvdvreken]

In our case: we pass on the SymfonyRequest object to the OAuth2 server from The PHP League with this method. It then uses the $request object to get the request body, which should been parsed (with a parsing method defined by the Content-Type header or application/x-www-form-urlencoded) by default. The $request->request ParameterBag is used here and here. It only works for application/x-www-form-urlencoded unless we manually create the $request->request ParameterBag before we set the request with setRequest() method from the AbstractServer class.

There are several people and issues with the request to support application/json like thephpleague/oauth2-server#292.