[13.x] Add attachFromStorage helpers to notification MailMessage#60268
Open
LucasCavalheri wants to merge 1 commit into
Open
[13.x] Add attachFromStorage helpers to notification MailMessage#60268LucasCavalheri wants to merge 1 commit into
LucasCavalheri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
attachFromStorageandattachFromStorageDiskhelpers to notificationMailMessage.These methods mirror the storage attachment API available on mailables and delegate to
Attachment::fromStorageDisk()before attaching the generated attachment to the message.Motivation
After #58201, mailables support attaching files directly from storage using dedicated helpers.
Notification mail messages can already attach
Attachmentinstances, but they do not provide the same convenience methods for storage-backed attachments. This creates a small API inconsistency betweenMailableand notificationMailMessage.Adding these helpers improves parity and makes notification mail attachments more ergonomic.
Changes
attachFromStorage()toMailMessageattachFromStorageDisk()toMailMessageAttachment::fromStorageDisk()Example
Tests
Added coverage in
NotificationMailMessageTest:testItAttachesFilesFromStoragetestItAttachesFilesFromStorageDiskVerified with:
Backward Compatibility
This change is fully backward compatible.
It only adds new convenience methods to notification
MailMessageand does not alter existing attachment behavior.